IRGen: address TODO for Windows static linking #41516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the static linking story on Windows by wiring up information about the static vs dynamic build of the module into the code generation for references to module external symbols. We now can indicate a module external symbol to be known local if it is expected to be internalized due to static linking. Even though the symbol may not be defined in the same module, the definition will be provided locally at link time. This avoids needing to resolve a dllimport'ed symbol to a local symbol at link time.
|
CC: @aschwaighofer |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the static linking story on Windows by wiring up
information about the static vs dynamic build of the module into the
code generation for references to module external symbols. We now can
indicate a module external symbol to be known local if it is expected to
be internalized due to static linking. Even though the symbol may not
be defined in the same module, the definition will be provided locally
at link time. This avoids needing to resolve a dllimport'ed symbol to a
local symbol at link time.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.