[move-function-value] Make sure that we propagate the debug scope from our original debug value into new undef debug values. #41521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m our original debug value into new undef debug values. Otherwise if the move is in a different scope, the backend will think that we have two different variables and emit the corresponding dwarf. After I have this commit in and my alloc stack hoising commit (via a different PR), I am going to be able to commit a full end <-> end test in lldb that values are printed out appropriately as their lifetimes begin/end.
|
@adrian-prantl Just more of what we have already talked about with the scope issue. |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise if the move is in a different scope, the backend will think that we
have two different variables and emit the corresponding dwarf.
After I have this commit in and my alloc stack hoising commit (via a different
PR), I am going to be able to commit a full end <-> end test in lldb that values
are printed out appropriately as their lifetimes begin/end.