[Reflection] Separate MemoryReader::resolvePointer to distinguish related operations #41530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test macOS |
kastiglione
changed the title
kastiglione
commented
Feb 24, 2022
Comment on lines
151
to
154
| virtual llvm::Optional<RemoteAbsolutePointer> | ||
| resolvePointerAsSymbol(RemoteAddress address) { | ||
| return llvm::None; | ||
| } |
There was a problem hiding this comment.
I have kept this in to allow this change to allow this PR to be free of a dependent change in llvm-project. Later, it will be removed.
mikeash
approved these changes
Feb 24, 2022
adrian-prantl
approved these changes
Feb 28, 2022
|
@swift-ci test |
kastiglione
deleted the
Reflection-Update-MemoryReader-to-distinguish-related-operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until recently,
MemoryReaderhad a single functionresovlePointerwhich did two things, and has a somewhat vague name. The two things were:swift-reflection-dumpand then later in lldb)Recently,
resolvePointerAsSymbolwas added, which overloaded the term "resolve" and it added another way to deal with symbols for addresses. Symbols themselves were a bit muddled, asswift-reflection-dumpwas dealing with dynamic symbols aka bindings, while lldb was dealing in regular (static) symbols.This change separates these two parts of functionality, and also divides symbol lookup into two cases. The API surface will now be:
resolvePointerfor mapping/tagging addressesgetSymbolfor looking up a symbol for an addressgetDynamicSymbolfor looking up a dyld binding for an addressNote: each of these names could be improved. Some alternative terms:
lookupinstead ofget,BindingorBindingNameinstead ofDynamicSymbol. Maybe even another term instead of "resolve". Suggestions welcome!Currently,
swift-reflection-dumpsupportsgetDynamicSymbolbut notgetSymbol. For lldb it's the reverse,getSymbolis supported butgetDynamicSymbolneeds to be implemented.For everything but lldb, this change is NFC. For lldb it fixes a bug where
LLDBMemoryReaderreturns regular symbols where we should instead be returning dynamic symbols.