Frontend: add a frontend flag to generate empty ABI descriptors to workaround deserialization issues #41538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
…rkaround deserialization issues ABI descriptors should always be emitted as sidecars for library-evolution-enabled modules. However, generating these files requires traversing the entire module (like indexing), which may hit additional deserialization issues. To unblock builds, this patch introduces a flag to skip the traversing logic so that we emit an empty ABI descriptor file. The empty file serves as a placeholder so that build system doesn't need to know the details.
|
@swift-ci please smoke test |
bnbarham
approved these changes
Feb 24, 2022
Comment on lines
+2514
to
+2522
| SWIFT_DEFER { | ||
| payload.allContsValues = &extractor.getAllConstValues(); | ||
| dumpSDKRoot(collector.getSDKRoot(), payload, OutputFile); | ||
| }; | ||
| if (Empty) { | ||
| return; | ||
| } | ||
| collector.lookupVisibleDecls({MD}); | ||
| extractor.extract(MD); |
There was a problem hiding this comment.
Works fine obviously, but I think:
if (!Empty) {
collector.lookupVisibleDecls({MD});
extractor.extract(MD);
payload.allContsValues = &extractor.getAllConstValues();
}
dumpSDKRoot(collector.getSDKRoot(), payload, OutputFile);
Is a little more obvious. dumpSDKRoot handles an empty PayLoad. Alternatively
if (Empty) {
dumpSDKRoot(collector.getSDKRoot(), OutputFile)
return;
}
Right after the collector is nice too.
There was a problem hiding this comment.
Thank you for taking a look! @bnbarham The reason I still prefer we set the payload to an empty array of constant values is that the client side, likely written in Swift, can still parse the JSON to get an empty table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABI descriptors should always be emitted as sidecars for library-evolution-enabled modules.
However, generating these files requires traversing the entire module (like indexing), which may
hit additional deserialization issues. To unblock builds, this patch introduces a flag to skip
the traversing logic so that we emit an empty ABI descriptor file. The empty file serves as
a placeholder so that the build system doesn't need to know the details.