Fix a use-after-free with task tracing #41539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
rjmccall
force-pushed
the
uaf-task-tracing
branch
from
5229497 to
f392185
Compare
|
@swift-ci Please test |
We cannot access the executed job after it has finished executing: - If it's a non-task job, it is always invalidated; such jobs are self-owning, and they are expected to destroy themselves after execution. - If it's a task, and it completes during execution, it will invalidate itself synchronously, e.g. by releasing itself. At this point, it must be assumed that the task memory has been releaed. - If it's a task, and it hasn't completed during execution, we are now racing with whatever event *does* complete the task. Any information we want to log about the job must be recorded when it starts to run. rdar://88817560
rjmccall
force-pushed
the
uaf-task-tracing
branch
from
f392185 to
c70d73c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
rokhinip
approved these changes
Feb 24, 2022
|
Adding Mike who added the tracing stuff |
mikeash
approved these changes
Feb 24, 2022
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please test Linux |
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Linux |
|
Unrelated LLDB failure. This is getting tiresome. |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot access the executed job after it has finished executing:
If it's a non-task job, it is always invalidated; such jobs are self-owning, and they are expected to destroy themselves after execution.
If it's a task, and it completes during execution, it will invalidate itself synchronously, e.g. by releasing itself. At this point, it must be assumed that the task memory has been releaed.
If it's a task, and it hasn't completed during execution, we are now racing with whatever event does complete the task.
Any information we want to log about the job must be recorded when it starts to run.
Fixes rdar://88817560