Sema: Warn about non-final classes conforming to protocols with a same-type requirement on 'Self' #41545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-type requirement on 'Self' This is unsound because it breaks covariance of protocol conformances on classes. See the test case and changelog entry for details.
slavapestov
force-pushed
the
non-final-class-self-same-type-requirement-conformance
branch
from
e02ad86 to
c98ddb9
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
Nice! I guess this also catches SR-10713? Edit: Ah looks like that's more or less |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test macOS |
|
@hamishknight Ah indeed, looks like you discovered the issue 3 years ago :) |
|
@hamishknight Also I found another related radar I filed last year: rdar://74944514. My commit here doesn't actually catch that case, but it will after a small change. I'll generalize it in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unsound because it breaks covariance of protocol conformances
on classes. See the test case and changelog entry for details.