[Importer] Wrap the VFS passed to Clang with an overlay FS instead #41546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Whoops, would help if I tested it with the LLVM change that it requires! |
|
@swift-ci please test |
|
@swift-ci please test |
`OverlayFileSystem` is very simple - it just passes along each request to each VFS it contains until one is successful (or none are). Use it when wrapping the VFS to pass down into the Clang invocation creation, instead of the much more complicated `RedirectingFileSystem`. This has the side effect of also fixing a case where due to a bug in `RedirectingFileSystem`, the originally passed in path will be returned regardless of `use-external-name`. While that should also be fixed, there is no reason to use this VFS here anyway. Added a small cursor info test case that should catch issues like this in the future.
bnbarham
force-pushed
the
use-overlay-fs-instead
branch
from
93cf869 to
bbc98aa
Compare
|
Good old Windows paths. They get me every time! |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OverlayFileSystemis very simple - it just passes along each requestto each VFS it contains until one is successful (or none are). Use it
when wrapping the VFS to pass down into the Clang invocation creation,
instead of the much more complicated
RedirectingFileSystem.This has the side effect of also fixing a case where due to a bug in
RedirectingFileSystem, the originally passed in path will be returnedregardless of
use-external-name. While that should also be fixed,there is no reason to use this VFS here anyway.
Added a small cursor info test case that should catch issues like this
in the future.