Skip to content

SILGen: Add missing processing to reabstraction fast-path. #41549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Feb 24, 2022

Calling into foreign-convention functions requires bridging, and the code
that bypassed reabstraction conversions failed to take this into account.
Fixes SR-15696 | rdar://89319249.

@jckarter
Copy link
Contributor Author

@swift-ci Please test

1 similar comment
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter jckarter force-pushed the disable-reabstraction-opt-for-foreign-convention branch from 9ec562d to eaa54e8 Compare February 25, 2022 19:00
@jckarter
Copy link
Contributor Author

@swift-ci Please test

Calling into foreign-convention functions requires bridging, and the code
that bypassed reabstraction conversions failed to take this into account.
Fixes rdar://89319249.
@jckarter jckarter force-pushed the disable-reabstraction-opt-for-foreign-convention branch from eaa54e8 to 7c9f13a Compare February 25, 2022 20:43
@jckarter jckarter changed the title SILGen: Back off reabstraction optimization when calling foreign-convention closures. SILGen: Add missing processing to reabstraction fast-path. Feb 25, 2022
@jckarter
Copy link
Contributor Author

@swift-ci Please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant