Skip to content

[CMake] Merge Clang's features file with Swift's #41590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

bnbarham
Copy link
Contributor

Clang has a new redirecting-with property in the VFS overlay files.
While this could be added to Swift's features as well, it is generally
the case that features provided by Clang can also be useful to know for
clients of Swift. Merge the features from Clang into Swift's features
file with the "clang-" prefix to differentiate them.

Clang has a new `redirecting-with` property in the VFS overlay files.
While this could be added to Swift's features as well, it is generally
the case that features provided by Clang can also be useful to know for
clients of Swift. Merge the features from Clang into Swift's features
file with the "clang-" prefix to differentiate them.
@bnbarham bnbarham requested review from akyrtzi and compnerd February 28, 2022 21:20
@bnbarham
Copy link
Contributor Author

Adds #41547 back in. Removed the file output entirely and changed the CMake side to just redirect stdout into the merged file instead.

@bnbarham
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@bnbarham
Copy link
Contributor Author

bnbarham commented Mar 1, 2022

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental installs locally seem to be good, I think this should be a good approach.

@bnbarham bnbarham merged commit 7abc8a4 into swiftlang:main Mar 2, 2022
@bnbarham bnbarham deleted the really-merge-clang-features branch March 2, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants