Sema: Fix cycle in structural type resolution via TypeChecker::diagnoseInvalidFunctionType() #41594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seInvalidFunctionType() Fixes rdar://problem/89583624.
slavapestov
force-pushed
the
rqm-foreign-function-type-cycle
branch
from
d538b34 to
b5fa1ac
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
| @convention(c) (UnsafeMutableRawPointer?, | ||
| UnsafeMutableRawPointer?, | ||
| UnsafeMutableRawPointer?) -> CInt | ||
| } |
There was a problem hiding this comment.
What's the cycle here? Just curious.
There was a problem hiding this comment.
DeclContext::getGenericSignature() => ... => TypeAliasDecl::getStructuralType() => TypeChecker::diagnoseInvalidFunctionType() => TypeBase::isRepresentable() => DeclContext::getGenericSignature()
I could fix isRepresentable() but there's no reason to perform semantic checks in structural mode at all, since we're going to revisit it in interface type mode anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/89583624.