Skip to content

[CodeCompletion] Some more code cleanup #41601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2022
Merged

[CodeCompletion] Some more code cleanup #41601

merged 2 commits into from
Mar 3, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 1, 2022

  • Extract common implementation of sawSolution and fallbackTypeCheck to TypeCheckCompletionCallback
  • Make CodeCompletionCallbacksImpl::addSuperKeywords a static method (This matches the other add*Keywords methods)

ahoppen added 2 commits March 1, 2022 09:36
@ahoppen
[CodeCompletion] Extract common implementation of sawSolution and fal…
1baa1f4 
…lbackTypeCheck to TypeCheckCompletionCallback
@ahoppen
[CodeCompletion] Make CodeCompletionCallbacksImpl::addSuperKeywords a…
d9f3324 
… static method

This matches the other add*Keywords methods.
@ahoppen ahoppen requested a review from rintaro March 1, 2022 08:38
@ahoppen
Copy link
Member Author

ahoppen commented Mar 1, 2022

@swift-ci Please smoke test

@ahoppen ahoppen merged commit a02c7e7 into swiftlang:main Mar 3, 2022
@ahoppen ahoppen deleted the pr/prepare-for-solver-based-arg-completion branch March 3, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @rintaro