[swift-inspect] Fix the swift-inspect build on Darwin. #41620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeash
force-pushed
the
fix-swift-inspect-darwin
branch
from
789a3bc to
11351a9
Compare
|
@swift-ci please smoke test |
compnerd
reviewed
Mar 2, 2022
|
|
||
| let module = CSSymbolGetSymbolOwner(symbol) | ||
| return (CSSymbolOwnerGetName(module), CSSymbolGetName(symbol)) | ||
| } | ||
| } | ||
|
|
||
| extension DarwinRemoteProcess { | ||
| internal func iterateHeap(_ body: (swift_addr_t, UInt64) -> Void) { |
There was a problem hiding this comment.
Not sure, I must have done that as part of some other fix by mistake. Put it back now.
| let addr = process.GetSymbolAddress(symbolName) | ||
| if let ptr = process.ReadBytes(addr, MemoryLayout<UInt>.size) { | ||
| let addr = process.getAddr(symbolName: symbolName) | ||
| if let ptr = process.read(address: addr, size: MemoryLayout<UInt>.size) { |
There was a problem hiding this comment.
These changes will be problematic for Windows support, but we can deal with it then.
We had a few typos and such from the recent reorganization.
mikeash
force-pushed
the
fix-swift-inspect-darwin
branch
from
11351a9 to
e29434d
Compare
mikeash
changed the title
|
@swift-ci please smoke test |
compnerd
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a few typos and such from the recent reorganization.
Same as #41619 except pulling from my fork.