AST: consider syntactic final in isPotentiallyOverridable(). NFC #41626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
reviewed
Mar 2, 2022
Also, rename isPotentiallyOverridable() to isSyntacticallyOverridable().
nkcsgexi
force-pushed
the
experiment-final-in-isPotentiallyOverridable
branch
from
80c666c to
1bc7039
Compare
nkcsgexi
changed the title
|
@swift-ci please smoke test |
|
swiftlang/llvm-project#4013 |
slavapestov
reviewed
Mar 3, 2022
| if (isa<VarDecl>(this) || | ||
| isa<SubscriptDecl>(this) || | ||
| isa<FuncDecl>(this) || | ||
| isa<DestructorDecl>(this)) { | ||
| if (static_cast<const ValueDecl*>(this)->isFinal()) { |
There was a problem hiding this comment.
You could just make isFinal() const :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment to test whether
isPotentiallyOverridable()can also takefinalinto account.