RequirementMachine: Enable -requirement-machine-abstract-signatures=verify by default #41631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
rqm-abstract-signatures-on-by-default
branch
2 times, most recently
from
68c8675 to
e540fda
Compare
slavapestov
force-pushed
the
rqm-abstract-signatures-on-by-default
branch
2 times, most recently
from
094bc6b to
f93382c
Compare
|
@hamishknight Enabling this flag by default and removing it from the stdlib cmake configuration will also address rdar://problem/89805970. |
…=> T.[Q] These rules would be fine since RHS simplification eliminates them, but they cause problems for the minimal conformances algorithm. To avoid introducing such rules, ensure that the critical pair of two property-like rules is itself a property-like rule instead of relying on subsequent simplifications sorting it out. See the new comment in RewriteSystem::computeCriticalPair() for details. I need to understand this problem better and either fix minimal conformances or add stronger assertions, but for now this fixes the last failure with -requirement-machine-abstract-signatures=verify.
slavapestov
force-pushed
the
rqm-abstract-signatures-on-by-default
branch
from
f93382c to
a0b71e9
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this needs to be reverted, it is sufficient to revert the final commit. The other commits should still pass tests with that one reverted.