Skip to content

RequirementMachine: Enable -requirement-machine-inferred-signatures=verify by default #41650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Mar 3, 2022

This also includes a hacky fix for rdar://89791117 since I just saw Linux corelibs-foundation was hitting it.

@slavapestov slavapestov changed the title Enable -requirement-machine-inferred-signatures=verify by default RequirementEnable -requirement-machine-inferred-signatures=verify by default Mar 3, 2022
@slavapestov slavapestov changed the title RequirementEnable -requirement-machine-inferred-signatures=verify by default RequirementMachine: Enable -requirement-machine-inferred-signatures=verify by default Mar 3, 2022
@slavapestov slavapestov force-pushed the rqm-inferred-signatures-on-by-default branch from e081406 to e5a6f5a Compare March 18, 2022 04:07
… in a handful of tests

- unify_superclass_types_[23].swift: I will fix these soon.
  rdar://90469643

- attr/accessibility_where_clause.swift: This one is dicey and should
  probably be banned. rdar://90469477
@slavapestov slavapestov force-pushed the rqm-inferred-signatures-on-by-default branch 2 times, most recently from 87d9105 to e110c0f Compare March 18, 2022 05:27
…te type

I'll clean this up, comment it and generalize it to work with protocol requirement
signatures soon. Landing this now to unblock the Linux corelibs-foundation build.

Fixes rdar://problem/89791117.
@slavapestov slavapestov force-pushed the rqm-inferred-signatures-on-by-default branch from e110c0f to 2206b1c Compare March 18, 2022 05:29
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov merged commit 0dd1311 into swiftlang:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant