[CodeSynthesis] Improve synthesized Decodable.init(from:) for enums
#41674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
rintaro
force-pushed
the
sema-codablesynth-rdar89150202
branch
from
674880b to
d2ae76b
Compare
|
@swift-ci Please test |
louisdh
reviewed
Mar 5, 2022
| guard container.allKeys.count == 1 else { | ||
| var allKeys = ArraySlice(container.allKeys) | ||
|
|
||
| guard let onlyKey = allKeys.popFirst(), allKeys.isEmpty else { |
There was a problem hiding this comment.
Perfect!
I was confused at first seeing allKeys.isEmpty. Then I realized it's mutating allKeys with the popFirst() (I initially just read it as accessing the first key, not removing it from the array).
Seems like a much more efficient (and safe) way for checking that's there's only 1 key. 😃
Since this implementation is exposed to users, we want to make it nice. * Don't use 'unsafelyUnwrapped' which is usually not recommended to use * Don't access 'container.allKeys' multiple times as it's a computed property rdar://89150202
rintaro
force-pushed
the
sema-codablesynth-rdar89150202
branch
from
d2ae76b to
1cfffb8
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsafelyUnwrappedwhich is usually not recommendedcontainer.allKeysmultiple times as it's a computed propertyBefore:
After:
rdar://89150202