Place Opened Archetypes in their Proper Generic Contexts #41677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
CodaFi
force-pushed
the
substitutions-available-upon-request
branch
from
3b34b0a to
1fe38b0
Compare
slavapestov
reviewed
Mar 7, 2022
| @@ -4421,6 +4422,11 @@ CanTypeWrapper<OpenedArchetypeType> OpenedArchetypeType::getNew( | |||
| GenericEnvironment *environment, Type interfaceType, | |||
| ArrayRef<ProtocolDecl *> conformsTo, Type superclass, | |||
| LayoutConstraint layout) { | |||
| // FIXME: It'd be great if all of our callers could submit interface types. | |||
There was a problem hiding this comment.
Callers should be able to provide a substitution map to map generic parameters to archetypes or type variables.
This ensures that opened archetypes always inherit any outer generic parameters from the context in which they reside. This matters because class bounds may bind generic parameters from these outer contexts, and without the outer context you can wind up with ill-formed generic environments like <τ_0_0, where τ_0_0 : C<T>, τ_0_0 : P> Where T is otherwise unbound because there is no entry for it among the generic parameters of the environment's associated generic signature.
…Composites The requirements are not always going to appear with superclass constraints last, so we still need to ensure that superclass bounds wind up at the head of the set of members.
CodaFi
force-pushed
the
substitutions-available-upon-request
branch
from
1fe38b0 to
445c494
Compare
|
@swift-ci smoke test |
CodaFi
force-pushed
the
substitutions-available-upon-request
branch
from
445c494 to
f694bf5
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of a refactoring intended to ultimately support a more generic representation of opened archetypes for parameterized protocol types.
This does a massive amount of plumbing to ensure that the
DeclContextcorresponding to the actual usage of an existential being opened is provided to abstractions dealing with opened archetypes. This allows us to extract any outer generic parameters and prepend them to the archetype's generic signature. This ultimately means that theSelfparameter of an opened archetype no longer corresponds totau_0_0, but instead resides atgeneric context depth + 1for most types. Protocol extensions are the exception as theSelftype appears astau_0_0in context anyways. Callers should use the newOpenedArchetypeType::getSelfInterfaceTypeFromContextinstead of constructing generic parameter types forSelf.