Temporarily disable LoopARC. #4170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please benchmark |
|
The please benchmark is unlikely to finish on time. Erik told me there is no significant performance regressions measured on his machine. |
Build comment file:Optimized (O)
|
| TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
|---|---|---|---|---|
| NSStringConversion | 900 | 1114 | +23.8% | 0.81x |
| ObjectiveCBridgeFromNSArrayAnyObjectToString | 146439 | 175273 | +19.7% | 0.84x |
| SetIsSubsetOf | 515 | 581 | +12.8% | 0.89x |
| ObjectiveCBridgeToNSSet | 22475 | 24621 | +9.6% | 0.91x(?) |
| Dictionary2 | 1950 | 2115 | +8.5% | 0.92x |
| Dictionary3 | 512 | 543 | +6.0% | 0.94x |
| CaptureProp | 4880 | 5217 | +6.9% | 0.94x |
| MapReduce | 419 | 446 | +6.4% | 0.94x |
| ObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 160448 | 170890 | +6.5% | 0.94x(?) |
Improvement (2)
| TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
|---|---|---|---|---|
| ObjectiveCBridgeStubFromNSString | 1026 | 958 | -6.6% | 1.07x(?) |
| ObjectiveCBridgeFromNSArrayAnyObjectForced | 8148 | 7188 | -11.8% | 1.13x(?) |
No Changes (125)
| TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
|---|---|---|---|---|
| DictionaryBridge | 6344 | 6119 | -3.5% | 1.04x |
| ObjectiveCBridgeStubToNSDate | 14020 | 13496 | -3.7% | 1.04x(?) |
| ErrorHandling | 3039 | 2916 | -4.0% | 1.04x(?) |
| ObjectiveCBridgeFromNSArrayAnyObject | 99813 | 95564 | -4.3% | 1.04x(?) |
| ObjectiveCBridgeFromNSSetAnyObjectForced | 4883 | 4676 | -4.2% | 1.04x(?) |
| ObjectiveCBridgeFromNSDictionaryAnyObjectForced | 6127 | 5970 | -2.6% | 1.03x(?) |
| ProtocolDispatch2 | 152 | 148 | -2.6% | 1.03x |
| ObjectiveCBridgeStubURLAppendPathRef | 362968 | 351258 | -3.2% | 1.03x(?) |
| ObjectiveCBridgeToNSString | 1065 | 1049 | -1.5% | 1.02x |
| AnyHashableWithAClass | 66813 | 65679 | -1.7% | 1.02x |
| SortStrings | 2490 | 2450 | -1.6% | 1.02x(?) |
| ObjectiveCBridgeStubFromNSDateRef | 3979 | 3886 | -2.3% | 1.02x(?) |
| PopFrontArrayGeneric | 1890 | 1856 | -1.8% | 1.02x(?) |
| StringEqualPointerComparison | 8584 | 8385 | -2.3% | 1.02x |
| ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 203313 | 198914 | -2.2% | 1.02x(?) |
| SetIsSubsetOf_OfObjects | 529 | 518 | -2.1% | 1.02x(?) |
| ObjectiveCBridgeFromNSSetAnyObjectToString | 216006 | 212141 | -1.8% | 1.02x(?) |
| StringWalk | 7197 | 7063 | -1.9% | 1.02x |
| ObjectiveCBridgeStubFromNSDate | 4005 | 3908 | -2.4% | 1.02x(?) |
| ArraySubscript | 1430 | 1422 | -0.6% | 1.01x(?) |
| StackPromo | 20230 | 20054 | -0.9% | 1.01x |
| StringWithCString | 155474 | 154646 | -0.5% | 1.01x |
| ObjectiveCBridgeFromNSStringForced | 2938 | 2902 | -1.2% | 1.01x(?) |
| ObjectiveCBridgeStubToNSString | 1258 | 1250 | -0.6% | 1.01x |
| StaticArray | 2940 | 2904 | -1.2% | 1.01x(?) |
| Walsh | 367 | 362 | -1.4% | 1.01x(?) |
| ObjectiveCBridgeToNSArray | 32830 | 32602 | -0.7% | 1.01x(?) |
| ObjectiveCBridgeStubToNSDateRef | 3303 | 3256 | -1.4% | 1.01x(?) |
| Hanoi | 3615 | 3597 | -0.5% | 1.01x |
| DictionaryRemoveOfObjects | 20762 | 20625 | -0.7% | 1.01x(?) |
| UTF8Decode | 360 | 357 | -0.8% | 1.01x |
| SortStringsUnicode | 9915 | 9835 | -0.8% | 1.01x |
| RGBHistogramOfObjects | 22700 | 22549 | -0.7% | 1.01x(?) |
| Phonebook | 7729 | 7670 | -0.8% | 1.01x |
| MonteCarloE | 10452 | 10383 | -0.7% | 1.01x(?) |
| StringHasPrefixUnicode | 15765 | 15636 | -0.8% | 1.01x(?) |
| TwoSum | 1972 | 1946 | -1.3% | 1.01x(?) |
| RecursiveOwnedParameter | 1991 | 1993 | +0.1% | 1.00x(?) |
| ClassArrayGetter | 15 | 15 | +0.0% | 1.00x |
| Array2D | 2812 | 2813 | +0.0% | 1.00x(?) |
| Histogram | 675 | 676 | +0.1% | 1.00x(?) |
| MonteCarloPi | 44447 | 44494 | +0.1% | 1.00x(?) |
| SortLettersInPlace | 995 | 993 | -0.2% | 1.00x(?) |
| DictionarySwap | 810 | 814 | +0.5% | 1.00x |
| PopFrontArray | 1855 | 1857 | +0.1% | 1.00x(?) |
| ArrayOfGenericPOD | 223 | 223 | +0.0% | 1.00x |
| StringHasPrefix | 832 | 832 | +0.0% | 1.00x |
| ByteSwap | 1 | 1 | +0.0% | 1.00x |
| XorLoop | 407 | 408 | +0.2% | 1.00x(?) |
| ProtocolDispatch | 3159 | 3157 | -0.1% | 1.00x(?) |
| ObjectAllocation | 158 | 158 | +0.0% | 1.00x |
| TypeFlood | 0 | 0 | +0.0% | 1.00x |
| ArrayLiteral | 1015 | 1013 | -0.2% | 1.00x(?) |
| SetIntersect_OfObjects | 2352 | 2342 | -0.4% | 1.00x(?) |
| Join | 474 | 473 | -0.2% | 1.00x(?) |
| ObjectiveCBridgeStubDateMutation | 258 | 259 | +0.4% | 1.00x |
| NSError | 338 | 337 | -0.3% | 1.00x(?) |
| PopFrontUnsafePointer | 8965 | 8967 | +0.0% | 1.00x(?) |
| PolymorphicCalls | 25 | 25 | +0.0% | 1.00x |
| RC4 | 250 | 251 | +0.4% | 1.00x |
| ObjectiveCBridgeStubToNSStringRef | 136 | 136 | +0.0% | 1.00x |
| Calculator | 40 | 40 | +0.0% | 1.00x |
| OpenClose | 68 | 68 | +0.0% | 1.00x |
| NopDeinit | 36999 | 36876 | -0.3% | 1.00x |
| ObjectiveCBridgeStubToArrayOfNSString | 32484 | 32568 | +0.3% | 1.00x(?) |
| SetIntersect | 1195 | 1194 | -0.1% | 1.00x(?) |
| SetExclusiveOr | 3914 | 3933 | +0.5% | 1.00x |
| ObjectiveCBridgeStubNSDateRefAccess | 346 | 346 | +0.0% | 1.00x |
| StringBuilder | 1311 | 1308 | -0.2% | 1.00x(?) |
| ArrayInClass | 91 | 91 | +0.0% | 1.00x |
| ArrayOfGenericRef | 3587 | 3573 | -0.4% | 1.00x(?) |
| StringHasSuffix | 947 | 947 | +0.0% | 1.00x |
| ObjectiveCBridgeStubDateAccess | 229 | 229 | +0.0% | 1.00x |
| Sim2DArray | 510 | 511 | +0.2% | 1.00x |
| ObjectiveCBridgeStubNSDateMutationRef | 12097 | 12070 | -0.2% | 1.00x(?) |
| StringHasSuffixUnicode | 73615 | 73935 | +0.4% | 1.00x |
| ArrayAppend | 766 | 765 | -0.1% | 1.00x(?) |
| LinkedList | 6386 | 6412 | +0.4% | 1.00x(?) |
| ObjectiveCBridgeFromNSSetAnyObjectToStringForced | 147592 | 146894 | -0.5% | 1.00x(?) |
| ArrayValueProp4 | 8 | 8 | +0.0% | 1.00x |
| SetUnion | 2863 | 2856 | -0.2% | 1.00x(?) |
| Chars | 664 | 664 | +0.0% | 1.00x |
| DeadArray | 172 | 172 | +0.0% | 1.00x |
| ArrayValueProp2 | 8 | 8 | +0.0% | 1.00x |
| BitCount | 1 | 1 | +0.0% | 1.00x |
| AngryPhonebook | 2926 | 2923 | -0.1% | 1.00x(?) |
| ArrayValueProp | 8 | 8 | +0.0% | 1.00x |
| GlobalClass | 0 | 0 | +0.0% | 1.00x |
| Memset | 214 | 215 | +0.5% | 1.00x |
| ArrayAppendReserved | 516 | 515 | -0.2% | 1.00x(?) |
| ArrayValueProp3 | 8 | 8 | +0.0% | 1.00x |
| DictionarySwapOfObjects | 6845 | 6931 | +1.3% | 0.99x(?) |
| 135 | 4127675 | 4189898 | +1.5% | 0.99x |
| Integrate | 248 | 250 | +0.8% | 0.99x |
| Prims | 751 | 756 | +0.7% | 0.99x(?) |
| StringInterpolation | 10581 | 10685 | +1.0% | 0.99x(?) |
| ObjectiveCBridgeStubFromNSStringRef | 154 | 156 | +1.3% | 0.99x(?) |
| ObjectiveCBridgeFromNSSetAnyObject | 375982 | 381489 | +1.5% | 0.99x(?) |
| StrComplexWalk | 3325 | 3349 | +0.7% | 0.99x(?) |
| IterateData | 2608 | 2637 | +1.1% | 0.99x |
| NSDictionaryCastToSwift | 14158 | 14236 | +0.6% | 0.99x(?) |
| HashTest | 1780 | 1790 | +0.6% | 0.99x(?) |
| DictionaryRemove | 5025 | 5078 | +1.1% | 0.99x(?) |
| RGBHistogram | 3215 | 3233 | +0.6% | 0.99x(?) |
| SevenBoom | 1377 | 1385 | +0.6% | 0.99x(?) |
| ObjectiveCBridgeStubNSDataAppend | 2643 | 2660 | +0.6% | 0.99x(?) |
| ObjectiveCBridgeFromNSDictionaryAnyObjectToString | 320361 | 328339 | +2.5% | 0.98x(?) |
| SuperChars | 208521 | 212890 | +2.1% | 0.98x(?) |
| ArrayOfRef | 3467 | 3533 | +1.9% | 0.98x(?) |
| ObjectiveCBridgeStubURLAppendPath | 337984 | 346476 | +2.5% | 0.98x(?) |
| ObjectiveCBridgeStubDataAppend | 3239 | 3309 | +2.2% | 0.98x(?) |
| SetExclusiveOr_OfObjects | 8304 | 8487 | +2.2% | 0.98x |
| ObjectiveCBridgeToNSDictionary | 25285 | 25855 | +2.2% | 0.98x(?) |
| ArrayOfPOD | 182 | 185 | +1.6% | 0.98x |
| StrToInt | 5597 | 5697 | +1.8% | 0.98x |
| ObjectiveCBridgeFromNSDictionaryAnyObject | 314648 | 324540 | +3.1% | 0.97x(?) |
| DictionaryLiteral | 4493 | 4622 | +2.9% | 0.97x |
| ObjectiveCBridgeFromNSString | 1929 | 1979 | +2.6% | 0.97x(?) |
| Dictionary3OfObjects | 869 | 903 | +3.9% | 0.96x |
| RangeAssignment | 362 | 376 | +3.9% | 0.96x |
| DictionaryOfObjects | 2293 | 2386 | +4.1% | 0.96x |
| Dictionary | 811 | 841 | +3.7% | 0.96x |
| SetUnion_OfObjects | 7034 | 7296 | +3.7% | 0.96x |
| Dictionary2OfObjects | 3390 | 3529 | +4.1% | 0.96x |
| ObjectiveCBridgeStubFromArrayOfNSString | 117496 | 124160 | +5.7% | 0.95x(?) |
Regression (6)
| TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
|---|---|---|---|---|
| NSStringConversion | 3138 | 3683 | +17.4% | 0.85x |
| ObjectiveCBridgeStubFromArrayOfNSString | 121363 | 138255 | +13.9% | 0.88x(?) |
| NopDeinit | 60704 | 66992 | +10.4% | 0.91x |
| ArrayOfPOD | 2374 | 2603 | +9.7% | 0.91x |
| ObjectiveCBridgeFromNSArrayAnyObjectToString | 157683 | 170644 | +8.2% | 0.92x |
| ObjectiveCBridgeStubURLAppendPath | 344226 | 374155 | +8.7% | 0.92x(?) |
Improvement (6)
| TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
|---|---|---|---|---|
| Histogram | 14596 | 13766 | -5.7% | 1.06x(?) |
| ObjectiveCBridgeFromNSArrayAnyObject | 101724 | 95270 | -6.3% | 1.07x(?) |
| ObjectiveCBridgeStubFromNSString | 1076 | 997 | -7.3% | 1.08x |
| ObjectiveCBridgeFromNSDictionaryAnyObjectForced | 9689 | 8864 | -8.5% | 1.09x(?) |
| ObjectiveCBridgeStubToNSDate | 15171 | 13510 | -10.9% | 1.12x |
| ObjectiveCBridgeFromNSSetAnyObjectForced | 10840 | 8823 | -18.6% | 1.23x |
No Changes (124)
| TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
|---|---|---|---|---|
| ObjectiveCBridgeStubToArrayOfNSString | 32737 | 31144 | -4.9% | 1.05x |
| ObjectiveCBridgeFromNSStringForced | 3497 | 3362 | -3.9% | 1.04x(?) |
| StaticArray | 32173 | 31081 | -3.4% | 1.04x(?) |
| Dictionary2 | 5387 | 5204 | -3.4% | 1.04x |
| ObjectiveCBridgeFromNSSetAnyObjectToStringForced | 165969 | 159233 | -4.1% | 1.04x(?) |
| ObjectiveCBridgeFromNSDictionaryAnyObjectToString | 347427 | 335958 | -3.3% | 1.03x(?) |
| Calculator | 1075 | 1043 | -3.0% | 1.03x |
| ObjectiveCBridgeToNSDictionary | 26124 | 25420 | -2.7% | 1.03x(?) |
| RGBHistogram | 56043 | 54244 | -3.2% | 1.03x |
| ObjectiveCBridgeStubFromNSDateRef | 4401 | 4313 | -2.0% | 1.02x |
| TypeFlood | 165 | 162 | -1.8% | 1.02x(?) |
| OpenClose | 488 | 478 | -2.0% | 1.02x |
| ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 212820 | 208466 | -2.0% | 1.02x(?) |
| Dictionary | 2767 | 2721 | -1.7% | 1.02x(?) |
| ObjectiveCBridgeStubNSDataAppend | 3126 | 3060 | -2.1% | 1.02x(?) |
| StringWalk | 26830 | 26388 | -1.6% | 1.02x |
| Integrate | 369 | 367 | -0.5% | 1.01x |
| SortStrings | 2903 | 2871 | -1.1% | 1.01x |
| SortLettersInPlace | 2627 | 2607 | -0.8% | 1.01x(?) |
| ObjectiveCBridgeFromNSDictionaryAnyObject | 332343 | 329628 | -0.8% | 1.01x(?) |
| Dictionary3OfObjects | 2702 | 2681 | -0.8% | 1.01x(?) |
| RangeAssignment | 24016 | 23860 | -0.7% | 1.01x(?) |
| SuperChars | 258775 | 255925 | -1.1% | 1.01x |
| ObjectiveCBridgeStubToNSString | 1342 | 1323 | -1.4% | 1.01x |
| Join | 1499 | 1490 | -0.6% | 1.01x |
| SetIntersect_OfObjects | 20457 | 20311 | -0.7% | 1.01x(?) |
| PolymorphicCalls | 1094 | 1088 | -0.6% | 1.01x(?) |
| IterateData | 10661 | 10574 | -0.8% | 1.01x(?) |
| Phonebook | 62627 | 62024 | -1.0% | 1.01x |
| ObjectiveCBridgeFromNSSetAnyObjectToString | 225176 | 223888 | -0.6% | 1.01x(?) |
| BitCount | 115 | 114 | -0.9% | 1.01x |
| ArrayValueProp2 | 2871 | 2841 | -1.0% | 1.01x(?) |
| ObjectiveCBridgeToNSString | 1107 | 1102 | -0.5% | 1.00x(?) |
| DictionarySwapOfObjects | 25496 | 25488 | -0.0% | 1.00x(?) |
| StackPromo | 133570 | 133189 | -0.3% | 1.00x(?) |
| RecursiveOwnedParameter | 10690 | 10659 | -0.3% | 1.00x |
| AnyHashableWithAClass | 78493 | 78507 | +0.0% | 1.00x(?) |
| ClassArrayGetter | 1338 | 1337 | -0.1% | 1.00x(?) |
| Array2D | 838486 | 839505 | +0.1% | 1.00x(?) |
| MonteCarloPi | 53588 | 53773 | +0.3% | 1.00x |
| DictionarySwap | 10848 | 10878 | +0.3% | 1.00x |
| ObjectiveCBridgeFromNSString | 5726 | 5708 | -0.3% | 1.00x(?) |
| StringHasPrefix | 1899 | 1895 | -0.2% | 1.00x |
| ByteSwap | 10 | 10 | +0.0% | 1.00x |
| XorLoop | 20156 | 20137 | -0.1% | 1.00x(?) |
| ProtocolDispatch | 5751 | 5745 | -0.1% | 1.00x(?) |
| ArrayLiteral | 1132 | 1127 | -0.4% | 1.00x(?) |
| ProtocolDispatch2 | 460 | 461 | +0.2% | 1.00x |
| HashTest | 5391 | 5367 | -0.5% | 1.00x(?) |
| ArrayOfRef | 9265 | 9305 | +0.4% | 1.00x(?) |
| ArrayAppend | 3959 | 3961 | +0.1% | 1.00x(?) |
| ObjectiveCBridgeStubDateMutation | 517 | 516 | -0.2% | 1.00x(?) |
| ObjectiveCBridgeToNSArray | 32500 | 32385 | -0.3% | 1.00x(?) |
| PopFrontArrayGeneric | 10123 | 10112 | -0.1% | 1.00x |
| StringEqualPointerComparison | 11057 | 11101 | +0.4% | 1.00x |
| CaptureProp | 131764 | 131902 | +0.1% | 1.00x(?) |
| ObjectiveCBridgeStubToNSStringRef | 177 | 177 | +0.0% | 1.00x |
| MapReduce | 48849 | 48665 | -0.4% | 1.00x |
| DictionaryLiteral | 25982 | 26070 | +0.3% | 1.00x(?) |
| Hanoi | 20117 | 20017 | -0.5% | 1.00x(?) |
| DictionaryRemoveOfObjects | 63191 | 63089 | -0.2% | 1.00x(?) |
| UTF8Decode | 44420 | 44207 | -0.5% | 1.00x(?) |
| SortStringsUnicode | 10275 | 10289 | +0.1% | 1.00x(?) |
| SetIsSubsetOf | 3242 | 3253 | +0.3% | 1.00x |
| SetIntersect | 20898 | 20905 | +0.0% | 1.00x(?) |
| SetExclusiveOr | 47062 | 47226 | +0.3% | 1.00x(?) |
| GlobalClass | 0 | 0 | +0.0% | 1.00x |
| ObjectiveCBridgeStubNSDateRefAccess | 1339 | 1339 | +0.0% | 1.00x |
| StringBuilder | 2682 | 2688 | +0.2% | 1.00x(?) |
| ArrayInClass | 3907 | 3907 | +0.0% | 1.00x |
| ArrayOfGenericRef | 9958 | 9970 | +0.1% | 1.00x(?) |
| StringHasSuffix | 1982 | 1981 | -0.1% | 1.00x(?) |
| ObjectiveCBridgeStubDateAccess | 1092 | 1092 | +0.0% | 1.00x |
| Sim2DArray | 14753 | 14735 | -0.1% | 1.00x |
| SetExclusiveOr_OfObjects | 67161 | 67029 | -0.2% | 1.00x(?) |
| MonteCarloE | 111808 | 111561 | -0.2% | 1.00x |
| SetUnion_OfObjects | 49958 | 50002 | +0.1% | 1.00x(?) |
| StringHasSuffixUnicode | 74895 | 75007 | +0.1% | 1.00x(?) |
| Walsh | 13895 | 13898 | +0.0% | 1.00x(?) |
| ObjectiveCBridgeToNSSet | 24041 | 24073 | +0.1% | 1.00x(?) |
| DictionaryRemove | 30709 | 30714 | +0.0% | 1.00x(?) |
| StringHasPrefixUnicode | 17224 | 17278 | +0.3% | 1.00x(?) |
| LinkedList | 27420 | 27351 | -0.2% | 1.00x(?) |
| ArrayValueProp4 | 2820 | 2825 | +0.2% | 1.00x(?) |
| SetUnion | 31544 | 31550 | +0.0% | 1.00x(?) |
| AngryPhonebook | 3066 | 3065 | -0.0% | 1.00x(?) |
| SevenBoom | 1519 | 1513 | -0.4% | 1.00x(?) |
| ArrayValueProp | 2357 | 2355 | -0.1% | 1.00x(?) |
| ObjectiveCBridgeStubNSDateMutationRef | 14540 | 14593 | +0.4% | 1.00x(?) |
| RC4 | 9295 | 9301 | +0.1% | 1.00x(?) |
| Memset | 21155 | 21164 | +0.0% | 1.00x(?) |
| Dictionary2OfObjects | 7002 | 7029 | +0.4% | 1.00x(?) |
| ArrayAppendReserved | 3696 | 3696 | +0.0% | 1.00x |
| TwoSum | 9570 | 9566 | -0.0% | 1.00x(?) |
| ArrayValueProp3 | 2868 | 2868 | +0.0% | 1.00x |
| ObjectiveCBridgeStubFromNSDate | 4335 | 4337 | +0.1% | 1.00x(?) |
| ArraySubscript | 5802 | 5860 | +1.0% | 0.99x(?) |
| PopFrontArray | 26242 | 26626 | +1.5% | 0.99x(?) |
| 135 | 6866696 | 6968548 | +1.5% | 0.99x |
| DictionaryBridge | 6226 | 6294 | +1.1% | 0.99x(?) |
| Prims | 15425 | 15613 | +1.2% | 0.99x |
| StringInterpolation | 15449 | 15588 | +0.9% | 0.99x(?) |
| ObjectiveCBridgeStubFromNSStringRef | 185 | 186 | +0.5% | 0.99x |
| ObjectAllocation | 556 | 560 | +0.7% | 0.99x(?) |
| Dictionary3 | 2046 | 2068 | +1.1% | 0.99x(?) |
| StrComplexWalk | 9127 | 9247 | +1.3% | 0.99x(?) |
| ObjectiveCBridgeStubURLAppendPathRef | 351910 | 353903 | +0.6% | 0.99x(?) |
| ObjectiveCBridgeStubDataAppend | 3678 | 3699 | +0.6% | 0.99x(?) |
| RGBHistogramOfObjects | 103940 | 105059 | +1.1% | 0.99x(?) |
| SetIsSubsetOf_OfObjects | 3073 | 3099 | +0.8% | 0.99x |
| DeadArray | 116529 | 118213 | +1.4% | 0.99x |
| StringWithCString | 146454 | 149611 | +2.2% | 0.98x |
| DictionaryOfObjects | 5744 | 5834 | +1.6% | 0.98x |
| ObjectiveCBridgeStubToNSDateRef | 3281 | 3352 | +2.2% | 0.98x |
| Chars | 5713 | 5825 | +2.0% | 0.98x |
| ObjectiveCBridgeFromNSArrayAnyObjectForced | 12815 | 13190 | +2.9% | 0.97x |
| ObjectiveCBridgeFromNSSetAnyObject | 387411 | 398253 | +2.8% | 0.97x(?) |
| ErrorHandling | 3701 | 3833 | +3.6% | 0.97x(?) |
| PopFrontUnsafePointer | 245306 | 255196 | +4.0% | 0.96x |
| ArrayOfGenericPOD | 4307 | 4487 | +4.2% | 0.96x |
| NSDictionaryCastToSwift | 15896 | 16552 | +4.1% | 0.96x(?) |
| ObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 177837 | 184630 | +3.8% | 0.96x(?) |
| NSError | 647 | 684 | +5.7% | 0.95x(?) |
| StrToInt | 6144 | 6467 | +5.3% | 0.95x |
|
That's, um, pretty significant. But better than a miscompile, I guess. |
|
we did not measure such regression locally, especially the NSStringConversion. maybe its just noise. we will see on zperf. |
|
zperf basically shows no regression, except noise |
kateinoigakukun
pushed a commit
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.