Stabilize and simplify SIL linkage and serialization #41703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
|
@swift-ci Please test compiler performance |
|
@swift-ci benchmark |
1 similar comment
|
@swift-ci benchmark |
|
@swift-ci Please test compiler performance |
|
@swift-ci test macOS |
1 similar comment
|
@swift-ci test macOS |
eeckstein
force-pushed
the
simplify-linkage
branch
from
398ce07 to
447d13d
Compare
|
@swift-ci test |
|
@swift-ci benchmark |
eeckstein
force-pushed
the
simplify-linkage
branch
from
447d13d to
ef18209
Compare
|
@swift-ci test |
slavapestov
approved these changes
Mar 8, 2022
include/swift/SIL/SILLinkage.h
Outdated
| @@ -38,33 +38,51 @@ enum class SILLinkage : uint8_t { | |||
| /// This object definition is visible to multiple Swift modules (and | |||
| /// thus potentially across linkage-unit boundaries). There are no | |||
| /// other object definitions with this name in the program. | |||
| /// | |||
| /// Public functions must be definitions, i.e. must have a body, except they | |||
| /// are clang imported. | |||
There was a problem hiding this comment.
Nitpick -- s/clang imported/body emitted by clang/? This is only true in a few narrow cases like bitfield accessors and static inline functions IIRC
eeckstein
force-pushed
the
simplify-linkage
branch
from
ef18209 to
3ff72d4
Compare
|
@swift-ci test |
|
@swift-ci benchmark |
The main point of this change is to make sure that a shared function always has a body: both, in the optimizer pipeline and in the swiftmodule file. This is important because the compiler always needs to emit code for a shared function. Shared functions cannot be referenced from outside the module. In several corner cases we missed to maintain this invariant which resulted in unresolved-symbol linker errors. As side-effect of this change we can drop the shared_external SIL linkage and the IsSerializable flag, which simplifies the serialization and linkage concept.
eeckstein
force-pushed
the
simplify-linkage
branch
from
3ff72d4 to
6a020f8
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this change is to make sure that a shared function always has a body: both, in the optimizer pipeline and in the swiftmodule file.
This is important because the compiler always needs to emit code for a shared function. Shared functions cannot be referenced from outside the module.
In several corner cases we missed to maintain this invariant which resulted in unresolved-symbol linker errors.
As side-effect of this change we can drop the shared_external SIL linkage and the IsSerializable flag, which simplifies the serialization and linkage concept.