IRGen: Differentiate between Swift.Bool and ObjCBool #4173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
slavapestov
force-pushed
the
bool-is-a-giant-mess-on-darwin-platforms
branch
from
a4d8920 to
7c464e7
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test os x |
|
@swift-ci Please test os x |
SIL already does this where necessary, except with foreign throwing functions; this patch changes Sema and the ClangImporter to give them an ObjCBool foreign error result type explicitly. This fixes a problem where calls to functions taking and returning the C99 _Bool type were miscompiled on Mac OS X x86-64, because IRGen was conflating the Objective-C BOOL type (which is a signed char on some platforms) and C99 _Bool (which lowers as the LLVM i1 type). Fixes <rdar://problem/26506458> and <rdar://problem/27365520>.
slavapestov
force-pushed
the
bool-is-a-giant-mess-on-darwin-platforms
branch
from
7c464e7 to
a21c748
Compare
|
@swift-ci Please smoke test OS X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as #4171, but for master.