[ClangImporter] Allow @Sendable on more params #41737
Merged
+309
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
beccadax
commented
Mar 9, 2022
When `__attribute__((swift_attr(“@sendable”)))` is applied to a clang parameter Swift now attempts to make the type `Sendable` in a more comprehensive way than before: * If it is a function type, it adds `@Sendable` to it. * If it is a protocol composition type, it adds `& Sendable` to it. * If it is a class, protocol, or generic class, it inserts it into a protocol composition and adds `& Sendable`. * If it is a typealias, it *may* desugar it to a modified version of the underlying type. * In various other cases, it recurses into the children of the type. This allows Objective-C methods and functions to require that their arguments have a Sendable type without specifying a particular type they must belong to. Fixes rdar://87727549.
beccadax
force-pushed
the
anything-can-be-sendable
branch
from
4f1f8d0 to
51e5408
Compare
|
I've replaced the previous implementation with one that's much more rigorous and easy to reason about, at the cost of being much more verbose. |
|
@swift-ci please smoke test |
etcwilde
reviewed
Mar 14, 2022
| // CHECK-NEXT: func sendProtos(_ obj: LabellyProtocol & ObjCClub & Sendable) | ||
| // CHECK-NEXT: func sendAnyArray(_ array: [Sendable]) | ||
| // CHECK-NEXT: func sendGeneric(_ generic: GenericObject<SendableClass> & Sendable) | ||
| // CHECK-NEXT: func sendPtr(_ val: UnsafeMutableRawPointer) |
There was a problem hiding this comment.
Should there be a warning about dropping the explicit sendability from the ObjC decl here and for the next function decl?
There was a problem hiding this comment.
I do emit some warnings through the experimental ClangImporter diagnostic infrastructure, but I don't want to rope that into these tests at its current stage of development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
__attribute__((swift_attr(“https://github.com/sendable”)))is applied to a clang parameter Swift now attempts to make the typeSendablein a more comprehensive way than before:@Sendableto it.& Sendableto it.& Sendable.This allows Objective-C methods and functions to require that their arguments have a Sendable type without specifying a particular type they must belong to.
Fixes rdar://87727549.