SILMem2Reg: fix a problem with leaking enum values #41744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When optimizing an enum `store` to an `alloc_stack`, require that all uses are in the same block. Otherwise it could be a `switch_enum` of an optional where the none-case does not have a destroy of the enum value. After transforming such an `alloc_stack`, the value would leak in the none-case block. It fixes the same OSSA verification error as done for TempRValueOpt in a previous commit.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When optimizing an enum
storeto analloc_stack, require that all uses are in the same block.Otherwise it could be a
switch_enumof an optional where the none-case does not have a destroy of the enum value.After transforming such an
alloc_stack, the value would leak in the none-case block.It fixes the same OSSA verification error as done for TempRValueOpt in #41724