Make toplevel vars MainActor with -warn-concurrency
#41763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last part to implement SE-0343. When `-warn-concurrency` is passed to the compiler invocation, we want to protect top-level variables behind the MainActor regardless of whether the top-level is an asynchronous context. Note that this does not make the top-level an asynchronous context, but it does annotate the top-level as being a main-actor-protected context.
|
@swift-ci please test |
compnerd
approved these changes
Mar 10, 2022
DougGregor
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part to implement SE-0343. When
-warn-concurrencyispassed to the compiler invocation, we want to protect top-level
variables behind the MainActor regardless of whether the top-level is an
asynchronous context. Note that this does not make the top-level an
asynchronous context, but it does put the top-level on the main actor,
so using main-actor-isolated variables is a synchronous operation from the top level.