Skip to content

[Distributed] rename _Distributed to module #41764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 10, 2022

Module rename is pretty tricky so we have to land it sooner rather than later.

@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Mar 10, 2022
@ktoso ktoso force-pushed the wip-flag-module branch 2 times, most recently from a80e6aa to 31add8a Compare March 10, 2022 14:01
@ktoso
Copy link
Contributor Author

ktoso commented Mar 10, 2022

@swift-ci please smoke test

@ktoso ktoso changed the title [Distributed] rename _Distributed to module & remove experimental flag [Distributed] rename _Distributed to module Mar 11, 2022
@ktoso
Copy link
Contributor Author

ktoso commented Mar 11, 2022

Flag removal in #41780

The module rename has to wait for a while.

@ktoso ktoso marked this pull request as draft March 11, 2022 02:55
@ktoso ktoso force-pushed the wip-flag-module branch from 99858f5 to 437cd4d Compare March 11, 2022 03:00
@ktoso
Copy link
Contributor Author

ktoso commented Mar 11, 2022

@swift-ci please smoke test

1 similar comment
@ktoso
Copy link
Contributor Author

ktoso commented Mar 11, 2022

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-flag-module branch from 82946e2 to 3e287c0 Compare March 15, 2022 08:40
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

Rebased and ready to go when CI stops being broken by unrelated tests.

@ktoso ktoso marked this pull request as ready for review March 15, 2022 08:40
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

Unblocked by swiftlang/swift-syntax#371

@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

@swift-ci please clean test and merge

@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

@swift-ci please smoke test and merge

1 similar comment
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

@swift-ci please smoke test and merge

@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

Sigh... a new file appeared on main so this PR made that break, rebased again.

@ktoso ktoso force-pushed the wip-flag-module branch from 683588a to 4796fb3 Compare March 15, 2022 23:37
@ktoso
Copy link
Contributor Author

ktoso commented Mar 15, 2022

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 704c7e1 into swiftlang:main Mar 16, 2022
@ktoso ktoso deleted the wip-flag-module branch March 16, 2022 02:42
@compnerd
Copy link
Member

This broke the Windows build because you didn't update all the references: https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/1154/

compnerd added a commit to compnerd/apple-swift that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants