[Distributed] IRGen: Don't emit accessor for distributed thunk specia… #41783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizations Only synthesized `async throws` version is directly accessible remotely. Resolves: rdar://90129442
|
@swift-ci please clean test |
ktoso
reviewed
Mar 11, 2022
| @@ -2239,7 +2239,7 @@ void IRGenSILFunction::emitSILFunction() { | |||
|
|
|||
| // Emit distributed accessor, and mark the thunk as accessible | |||
| // by name at runtime through it. | |||
| if (CurSILFn->isDistributed() && CurSILFn->isThunk()) { | |||
| if (CurSILFn->isDistributed() && CurSILFn->isThunk() == IsThunk) { | |||
There was a problem hiding this comment.
Whoa, I see...
Thank you so much for the fix 🙏
There was a problem hiding this comment.
Moving everything into AST enabled optimizations at call sites, which is nice.
There was a problem hiding this comment.
Yeah, very cool to see that! A bit of a pain to adjust everything but fantastic that we get those benefits <3
ktoso
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lizations
Only synthesized
async throwsversion is directly accessible remotely.Resolves: rdar://90129442