[CodeCompletion] Remove a hack adding type matching nominal types #41787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
Previously we didn't give any type relations to cached imported symbols. So there was a hack to add the type matching nominal type with type relation manually, which caused duplicated candiates, one from the cache, one added manually. Now that we have type relations for cached symbols so we don't need this hack anymore. rdar://90136020
rintaro
force-pushed
the
ide-completion-rdar90136020
branch
from
af20792 to
504e73d
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
|
Fixing a test case by removing code always sounds good to me 👍 |
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we didn't give any type relations to cached imported symbols. So there was a hack to add the type matching nominal type with type relation manually, which caused duplicated candidates, one from the cache, one added manually.
Now that we have type relations for cached symbols so we don't need this hack anymore.
rdar://90136020