Skip to content

Revert "[test] Disable a couple of DebugInfo tests" #41793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

This reverts commit a182a70.

I also fixed the tests as well.

NOTE: In the generic case of debug_value_addr, the self parameter with asserts
seems to be a var and without asserts a let. This is apparent at the AST level
before we even get to anything that I have changed. This seems to suggest that
there is some sort of uninitialized memory or something like that. Regardless
that is more of an AST level thing, so I just put in a regex that match both
patterns and send rdar://89237318 over to Robert Widmann!

This reverts commit a182a70.

I also fixed the tests as well.

NOTE: In the generic case of debug_value_addr, the self parameter with asserts
seems to be a var and without asserts a let. This is apparent at the AST level
before we even get to anything that I have changed. This seems to suggest that
there is some sort of uninitialized memory or something like that. Regardless
that is more of an AST level thing, so I just put in a regex that match both
patterns and send rdar://89237318 over to Robert Widmann!
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

@swift-ci test apple silicon

@gottesmm
Copy link
Contributor Author

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset macOS

1 similar comment
@gottesmm
Copy link
Contributor Author

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset macOS

@gottesmm
Copy link
Contributor Author

Looks like build-preset isn't working...

@gottesmm gottesmm merged commit d397821 into swiftlang:main Mar 12, 2022
@gottesmm gottesmm deleted the pr-f5659d1145565a5c7ea88bc8ee166c0dc1d1f1c4 branch March 12, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant