[Distributed] Add name parameter to recordArgument for better interop #41799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-argumentNameRecording
branch
from
7ec88ea to
54b9480
Compare
|
@swift-ci please smoke test |
xedin
reviewed
Mar 14, 2022
|
Unblocked by swiftlang/swift-syntax#371 |
ktoso
added
swift evolution pending discussion
ktoso
force-pushed
the
wip-argumentNameRecording
branch
from
54b9480 to
5a5d1ba
Compare
|
RemoteCallArgument implemented 🎉 Was more painful than I would have expected but we managed thanks to @hamishknight's amazing help and hints how to apply the generic type info properly there. Thanks and I'm going ahead with merging this though the exact details are pending evolution -- maybe we'll change names of labels or something, but this API is definitely much better than previous iteration. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test windows |
|
亲，你的信件我已收到，我会在最快的时间内来处理，谢谢合作！
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows better interop with various other targets, for example by storing invocation arguments along with their labels if the target of the call expects a JSON object (non swift targets come to mind).
We can also store the names or use them in diagnosis errors and more.