[cxx-interop] Test for apinotes fix in llvm-project. #41827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hyp @zoecarver @drodriguez @bulbazord This is my end to end swift test to go with swiftlang/llvm-project#4074 I still want to get the clang-only lit test on the llvm-project side working, but if we want to land what we have here for now that is fine too. |
|
@swift-ci please smoke test |
This is the test that goes with swiftlang/llvm-project#4074 In the PR to apple/llvm-project we were bailing on DeclContexts that were not isFileContext == true. This is problematic because with C++-Interop enabled we can end up with a DeclContext that is an extern "C". This test makes sure that the APINote is applied and that the code from the 4074 PR no longer bails out.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux Platform |
|
Want to test again or just merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the test that goes with swiftlang/llvm-project#4074
In the PR to apple/llvm-project we were bailing on DeclContexts that
were not isFileContext == true. This is problematic because with
C++-Interop enabled we can end up with a DeclContext that is an extern
"C". This test makes sure that the APINote is applied and that the code
from the 4074 PR no longer bails out.
Note: The llvm-project change is in apple/llvm-project rather than llvm/llvm-project because the file clang/lib/Sema/SemaAPINotes.cpp has not been upstreamed to llvm.org yet.