RequirementMachine: Fix bad interaction between rule sharing and conditional requirement inference #41838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents as an rvalue
…System::initialize()
…onditionalRequirements() This fixes a regression from the rule sharing implementation; I forgot to handle the imported rules in builder.ImportedRules here. This makes the usage of RuleBuilder in conditional requirement inference look like the other usages of RuleBuilder, except that the results are passed to RewriteSystem::addRules() instead of RewriteSystem::initialize().
Completion has a maximum rule limit since the Knuth-Bendix algorithm is a semi-decision procedure that does not terminate on all inputs. However, this means that generic signatures which import a large number of complex protocols can hit the limit even if they are convergent. Since imported rules are essentially free, ignore them here, to avoid having to increase the limit by hand. Now the default limit is 4000 local rules per requirement machine; it seems implausible that you would exceed this, but if anyone has an example we can bump the limit again.
slavapestov
force-pushed
the
rqm-conditional-requirement-inference-vs-rule-sharing
branch
from
26132bc to
6e6c8c2
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this by inspection after merging 26132bc3e96e4c190da4efc624dcd505b435e58b; I forgot to add imported rules from protocols appearing on the right hand sides of conditional requirements.
None of our existing test cases caught this, so I added a new test.
I refactored the RuleBuilder so that the weird thing that conditional requirement inference does where it adds new requirements to a rewrite system during completion is now much cleaner.
Also this PR adds an unrelated performance/diagnostics test case from an old radar.