Do not escape UNICODE when writing out target info. #41844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
Escaping unicode characters results in invalid JSON. - Refactor writeEscaped routine into StringExtras Resolves rdar://90108531
artemcm
force-pushed
the
TargetInfoCarefulJSON
branch
from
be9c00d to
57518b5
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Mar 17, 2022
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escaping unicode characters results in invalid JSON.
Refactor
writeEscapedroutine intoStringExtrasbecause it is also used insourcekitd.Resolves rdar://90108531