-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ConstraintSystem] Implement simplification for all locator elements #41847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xedin
merged 15 commits into
swiftlang:main
from
xedin:add-missing-locator-simplifications
Mar 17, 2022
Merged
[ConstraintSystem] Implement simplification for all locator elements #41847
xedin
merged 15 commits into
swiftlang:main
from
xedin:add-missing-locator-simplifications
Mar 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thesized}Argument` elements
…Component}Result` elements
…rchetype}` elements
@swift-ci please test |
@swift-ci please test source compatibility |
@swift-ci please test source compatibility debug |
hborla
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Failure in swift-protobuf-plugin is unrelated - |
… OptionalPayload, and IUO Choice
…d time has been exceeded
04f9001
to
2c35b65
Compare
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
default
insimplifyLocatorToAnchor
and implement simplificationlogic for all missing elements. This makes
simplifyLocatorToAnchor
future-proof.