Skip to content

[ConstraintSystem] Implement simplification for all locator elements #41847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 17, 2022

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Mar 16, 2022

Remove the default in simplifyLocatorToAnchor and implement simplification
logic for all missing elements. This makes simplifyLocatorToAnchor future-proof.

@xedin xedin requested a review from hborla March 16, 2022 22:41
@xedin
Copy link
Contributor Author

xedin commented Mar 16, 2022

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Mar 16, 2022

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Mar 17, 2022

@swift-ci please test source compatibility debug

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xedin
Copy link
Contributor Author

xedin commented Mar 17, 2022

Failure in swift-protobuf-plugin is unrelated - sandbox-exec: <internal init prelude>:456:12: unable to open system.sb: not found

@xedin xedin force-pushed the add-missing-locator-simplifications branch from 04f9001 to 2c35b65 Compare March 17, 2022 07:51
@xedin
Copy link
Contributor Author

xedin commented Mar 17, 2022

@swift-ci please test

@xedin xedin merged commit e94abe4 into swiftlang:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants