Parse: Require a "before: " label in @_backDeploy attribute #41893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
add-before-label-to-back-deploy-attr
branch
from
17f5fab to
8855edb
Compare
…e @_backDeploy attribute in order to match the pitched syntax for the attribute. Refactor existing comma separated list parsing code to take advantage of part of it in the attribute parsing.
tshortli
force-pushed
the
add-before-label-to-back-deploy-attr
branch
from
8855edb to
2a646dc
Compare
xymus
reviewed
Mar 18, 2022
xymus
approved these changes
Mar 18, 2022
|
@swift-ci please test |
tshortli
added a commit
to tshortli/swift-syntax
that referenced
this pull request
Mar 18, 2022
|
@swift-ci please test |
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require a "before: " label in the first item of the list in the
@_backDeployattribute in order to match the pitched syntax for the attribute:The previous implementation of parsing the
@_backDeployattribute body used theparseList()utility. With the addition of the "before:" label, it was no longer possible to use that utility unchanged because the necessary syntax node creation could not be nested properly to match the following grammar:I refactored the loop body out of
parseList()into a separateparseListItem()function that could be used by the attribute parsing implementation, avoiding duplication of much of the list parsing logic while also allowing more control over syntax node creation.Resolves rdar://90374640