[CodeCompletion] Migrate AccessorBeginning to solver-based #41922
Conversation
ahoppen
force-pushed
the
pr/migrage-accessorbeginning-solver-based
branch
2 times, most recently
from
96b1cca to
28fcdc1
Compare
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test |
lib/IDE/CodeCompletion.cpp
Outdated
| if (!CodeCompleteTokenExpr) { | ||
| // Happens when completing inside e.g. | ||
| // var x: Int { | ||
| // get { ... } | ||
| // #^COMPLETE^# | ||
| // } |
There was a problem hiding this comment.
I'm confused. You modified parseGetSet to pass the CodeCompletionExpr. Is this reachable?
There was a problem hiding this comment.
If we don't have a test case checking not suggesting expressions here, could you add some?
There was a problem hiding this comment.
Good catch, I did apparently fix the bug multiple times in incompatible ways. I updated the PR.
We basically have test cases to test we aren’t producing expressions in complete_accessor.swift, where a lot of global results are disallowed in these places. The way it worked in this PR was that completion lookup simply failed completely and didn’t produce any results, which left us with the keyword results only.
lib/IDE/CodeCompletion.cpp
Outdated
| assert(CurDeclContext); | ||
|
|
||
| addKeywords(CompletionContext.getResultSink(), MaybeFuncBody); |
There was a problem hiding this comment.
I think you should remove another addKeyword call below (Line 1426)
|
Also please remove the existing |
ahoppen
force-pushed
the
pr/migrage-accessorbeginning-solver-based
branch
from
28fcdc1 to
fa98911
Compare
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
lib/IDE/CodeCompletion.cpp
Outdated
| if (!Lookup.gotCallback()) { | ||
| Lookup.fallbackTypeCheck(CurDeclContext); | ||
| if (CodeCompleteTokenExpr) { | ||
| // Happens when completing inside e.g. |
There was a problem hiding this comment.
| // Happens when completing inside e.g. | |
| // 'CodeCompletionTokenExpr == nullptr' happens when completing inside e.g. |
because this is inside if (CodeCompeltionToken) branch.
ahoppen
force-pushed
the
pr/migrage-accessorbeginning-solver-based
branch
from
fa98911 to
8cd5bbd
Compare
|
@swift-ci Please smoke test |
Migrate code completion at the start of an accessor to solver-based.