GSB: Relax verify check some more in RequirementSignatureRequest #41925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GSB sometimes emits redundant same-type requirements here. Only checking for a prefix would still trigger false positives, so relax it all the way to only consider conformance requirements, which are the important ones from an ABI standpoint.
slavapestov
force-pushed
the
gsb-relax-verify-check-more
branch
from
c3b9307 to
404eb2c
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GSB sometimes emits redundant same-type requirements here. Only
checking for a prefix would still trigger false positives, so relax
it all the way to only consider conformance requirements, which
are the important ones from an ABI standpoint.