RequirementMachine: Another silly GenericSignatureBuilder compatibility hack for concrete contraction #41935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty hack for concrete contraction
slavapestov
force-pushed
the
rqm-concrete-contraction-unrelated-alias
branch
from
d7bb4db to
dc82433
Compare
|
@xedin This should fix the source compatibility test failure. |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
| @@ -0,0 +1,48 @@ | |||
| // R/UN: %target-swift-frontend -typecheck %s -debug-generic-signatures -requirement-machine-inferred-signatures=on 2>&1 | %FileCheck %s | |||
There was a problem hiding this comment.
Is this RUN line disabled deliberately?
Comment on lines
+24
to
+28
| init<Proxy: DelegateProxyType>(_: Proxy.Type) | ||
| where Proxy: GenericDelegateProxy<P, D>, | ||
| Proxy.Parent == P, | ||
| Proxy.Delegate == D {} | ||
| } |
There was a problem hiding this comment.
Trying to wrap my head around this. If the class is unrelated to the protocol, and the Proxy subclass could have its own distinct witnesses for these associated types, why would it be correct to substitute GenericDelegateProxy<P, D> into Proxy.Parent == P and discard the requirement?
There was a problem hiding this comment.
I updated the test in #42005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.