Follow-up for fixing IDE/SourceKit tests after changes for [SE-0111] #4195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://27642873
Also fixup 'test/SourceKit/CodeExpand/code-expand.swift' and use the syntax for adding parameter names with an underscore for first name.
- Make sure VarDecls have an associated TypeLoc, like ParamDecls do, then use it for printing the VarDecl's type. This is done by moving ParamDecl's TypeLoc up to the VarDecl. This is useful for being able to display the parameter names of function types embedded in VarDecls. - Use the result TypeLoc of functions for printing. This enables printing parameter names of function types embedded in return types. - Make sure to annotate attributes while they are printed.
|
@swift-ci smoke test OS X platform |
|
@swift-ci test OS X platform |
|
test/IDE/complete_from_stdlib.swift fails because of a stdlib difference between the branches, will update the test. |
…tdlib difference in swift-3 branch.
|
@swift-ci test OS X |
|
@swift-ci test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Reviewed by Ben Langmuir.
These are changes for fixing fallout on IDE/SourceKit after changes related to [SE-0111].
The changes are intrusive but they fix critical problems, for example failing to show external argument names in code-completion or cursor-info not showing local parameter names in function types.
Resolved bug number: (SR-)
rdar://27642873
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.