Skip to content

[ResultBuilders] Enable SE-0348 buildPartialBlock by default. #41966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Mar 22, 2022

When SE-0348 is approved, this patch enables buildPartialBlock feature by default. The frontend flag is kept for compatibility with existing clients, but is now ineffective.

Also includes some improved (?) error messages for invalid result builder call sites. Please let me know how it looks.

Enables SE-0348 `buildPartialBlock` feature by default. The frontend flag is kept for compatibility with existing clients, but is now ineffective.

Also includes some improved error messages for invalid result builder call sites.
@rxwei rxwei requested review from hborla and xedin March 22, 2022 23:30
@rxwei
Copy link
Contributor Author

rxwei commented Mar 22, 2022

@swift-ci please test

@rxwei
Copy link
Contributor Author

rxwei commented Apr 5, 2022

The proposal has been accepted.

@rxwei rxwei marked this pull request as ready for review April 5, 2022 02:17
@rxwei
Copy link
Contributor Author

rxwei commented Apr 5, 2022

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 882edde into swiftlang:main Apr 5, 2022
@rxwei rxwei deleted the se-0348-if-approved branch April 5, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants