-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Change env python
to env python3
#41981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -1,4 +1,4 @@ | |||
#!/usr/bin/env python | |||
#!/usr/bin/env python3 | |||
|
|||
from __future__ import print_function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should drop __future__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is intended as just dropping all the shebangs and not doing any compatibility cleanups, just making it easy to test if anything breaks with Python 3 (since all the __future__
etc. should keep working)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably shouldn't be merged at all
I suggest you erase this line too since there is no need for python 2.7 after these modifications. In the case of macOS 12.3 that Python2.7 isn't in
|
Going to just run some of the CI jobs on this |
@swift-ci please test |
@swift-ci Please Python lint |
@swift-ci Please smoke benchmark |
I don't see any of the other PRs doing a full replacement of all the shebangs—this just changes all of them without doing any of the work to make sure that's fine.