[cxx-interop] Import size_t as Int instead of UInt on Linux
#42003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
hyp
reviewed
Mar 24, 2022
| @@ -7,4 +7,8 @@ void foo(int x) {} | |||
|
|
|||
| }; // namespace FakeNamespace | |||
|
|
|||
| namespace std { | |||
| typedef unsigned long size_t; | |||
There was a problem hiding this comment.
will this get tested on windows? size_t needs unsigned long long for the windows target.
There was a problem hiding this comment.
This won't be tested on Windows, since Clang on Windows doesn't support -stdlib=libc++ which is used for fake toolchain tests.
There was an effort to support it in Clang, however, the patch got reverted: https://reviews.llvm.org/D101479
When using libc++, Swift imports `size_t` as Int despite `size_t` being an unsigned type. This is intentional & is specified in `lib/ClangImporter/MappedTypes.def`. Previously, MappedTypes were only honored for C/C++ types declared on the file level. In libstdc++, `size_t` is declared within `namespace std` and not on the file level, so the mapping to Int was not applied. This change ensures that MappedTypes are also applied to types declared in `namespace std`.
egorzhdan
force-pushed
the
egorzhdan/cxx-size_t-libstdcxx
branch
from
4948769 to
626eadc
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using libc++, Swift imports
size_tas Int despitesize_tbeing an unsigned type. This is intentional & is specified inlib/ClangImporter/MappedTypes.def. Previously, MappedTypes were only honored for C/C++ types declared on the file level.In libstdc++,
size_tis declared withinnamespace stdand not on the file level, so the mapping to Int was not applied.This change ensures that MappedTypes are also applied to types declared in
namespace std.