[CodeCompletion][Sema] Multiple improvements to prepare for migration of PostfixExprParen to solver-based #42006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
approved these changes
Mar 24, 2022
…or code completion This makes sure we e.g. resolve dependent member types after we perform type variable to generic parameter substitutions for code completion
…ompletion token is the first one in a call
This makes sure we don't penalize overloads with no arguments when calling
```swift
func foo() {}
func foo(_ arg: Int) {}
foo(#^COMPLETE^#
```
… function type During code completion, the function type may be a placeholder type. Don't crash in those cases.
…ucntion is defined
…completion We are doing global completion for function arguments, so we should also record the variable types determined by the solution.
ahoppen
force-pushed
the
pr/prepare-for-migrate-postfixexprparen
branch
from
2e07ec1 to
2d7dbd3
Compare
|
Removed on change (Don't increase the score for holes at the code completion token) from this PR because it was causing stress tester failures. I’m looking at addressing it in a separate PR. |
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
rintaro
approved these changes
Mar 25, 2022
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of multiple changes, which I hope aren’t too controversial, that are needed to migrate PostfixExprParen to solver-based. It might make sense to look at the commits individually for review to see the scope of each change.