Skip to content

Fully remove distributed checks #42008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

DougGregor
Copy link
Member

Eliminate some vestiges of the "experimental" flag for distributed actors. They're enabled by default, so all of this code is dead.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

@shahmishal
Copy link
Member

@swift-ci please smoke test

@shahmishal
Copy link
Member

@swift-ci please smoke test Windows

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! I tried to just always enable it but i guess got it wrong somehow still... Let's confirm it with a toolchain -- thank you!

@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Mar 24, 2022
@ktoso
Copy link
Contributor

ktoso commented Mar 24, 2022

macOS build failed rather weirdly, CI node died or something?
@swift-ci please smoke test macOS

Distributed actors are enabled by default, so we don't need this flag
any more.
Nothing is using it because this feature is enabled by default.
@DougGregor DougGregor force-pushed the fully-remove-distributed-checks branch from 2379db4 to c4e6e6d Compare March 24, 2022 23:00
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@ktoso
Copy link
Contributor

ktoso commented Mar 25, 2022

Thanks again! I'm downloading the toolchain and will verify if this was indeed it

@ktoso ktoso merged commit 1e821f2 into swiftlang:main Mar 25, 2022
@DougGregor DougGregor deleted the fully-remove-distributed-checks branch March 25, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants