Skip to content

[SILOpt] Run DestroyAddrHoisting in the mandatory pipeline when optimizing. #42019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

nate-chandler
Copy link
Contributor

Run SSADestroyHoisting in the pipeline where DestroyHoisting was previously running.

rdar://90495704

@nate-chandler nate-chandler requested a review from atrick March 25, 2022 04:01
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nate-chandler nate-chandler changed the title [SILOpt] Run SSADestroyHoisting in mandatory pipeline. [SILOpt] Run DestroyAddrHoisting in the mandatory pipeline when optimizing. Mar 28, 2023
@nate-chandler nate-chandler force-pushed the rdar90495704 branch 2 times, most recently from 4a657d5 to 81aa995 Compare March 28, 2023 18:07
@nate-chandler nate-chandler force-pushed the rdar90495704 branch 3 times, most recently from 271ef48 to 3d76eb6 Compare March 29, 2023 17:32
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macOS platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Run DestroyAddrHoisting in the pipeline where DestroyHoisting was
previously running.  Avoid extra ARC traffic that having no form of
destroy hoisting in the mandatory pipeline results in.

rdar://90495704
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler merged commit 7e15303 into swiftlang:main Apr 4, 2023
@nate-chandler nate-chandler deleted the rdar90495704 branch April 4, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants