[ConstraintSystem] Only attempt to infer a type from a default argument if there is a non-null callee. #42022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if there is a non-null callee. Otherwise, getParameterList(callee) will crash if the callee is a closure. Closures can't have default arguments anyway, so there's no need to attempt this new inference.
xedin
approved these changes
Mar 25, 2022
is no parameter list for the callee. This can happen when the callee is a closure that has been assigned to a variable.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
getParameterList(callee)will crash if the callee is a closure. Closures can't have default arguments anyway, so there's no need to attempt this new inference.