build libdispatch by default in both linux build bot configurations #4203

phausler · 2016-08-10T21:34:56Z

What's in this pull request?

Foundation is prepared to handle building libdispatch by default for Linux targets. This should add libdispatch as a default argument to the build script for the build bots.

phausler · 2016-08-10T21:35:09Z

@swift-ci Please test Linux

tkremenek · 2016-08-13T14:25:38Z

@swift-ci test

compnerd · 2016-08-13T16:30:11Z

@swift-ci please smoke test

tkremenek · 2016-08-14T17:16:47Z

@swift-ci test linux

RLovelett · 2016-08-14T21:19:05Z

utils/build-presets.ini

@@ -722,6 +724,7 @@ llbuild
 swiftpm
 xctest
 foundation
+lbidispatch


I cannot help but feel this is a typo.

Yep totally is, will have that fixed tomorrow when I am at a machine to be able to edit it.

Sent from my iPhone

On Aug 14, 2016, at 2:19 PM, Ryan Lovelett [email protected] wrote:

In utils/build-presets.ini:

@@ -722,6 +724,7 @@ llbuild
swiftpm
xctest
foundation
+lbidispatch
I cannot help but feel this is a typo.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

phausler · 2016-08-15T16:20:08Z

Updated this to correctly spell libdispatch per @RLovelett 's catch.

jrose-apple · 2016-08-15T19:55:20Z

@swift-ci Please test Linux platform

jrose-apple · 2016-08-15T19:55:29Z

@swift-ci Please smoke test OS X platform

jrose-apple · 2016-08-15T22:46:48Z

It looks like this finished despite not updating GitHub: OS X smoke passed, Linux failed.

tkremenek · 2016-08-16T04:16:20Z

@swift-ci test linux

phausler · 2016-08-16T15:34:49Z

Looks like the failure for linux was

/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/llbuild/tests/BuildSystem/Build/missing-inputs.llbuild:13:18: error: expected string not found in input

does llbuild use libdispatch?

phausler · 2016-08-16T15:37:19Z

@jrose-apple It looks like the previous failure of missing autoconf on the builders has been resolved.

jrose-apple · 2016-08-16T15:46:40Z

@swift-ci Please test Linux platform

jrose-apple · 2016-08-16T15:46:49Z

@swift-ci Please smoke test OS X platform

RLovelett · 2016-08-16T15:52:11Z

This might be a duplicate of #4315 (or it a duplicate of this). Just thought I'd point that out so that effort is not duplicated (as it is starting to look like it is).

Also, you might want to check out this comment. I think this will likely become a problem on this PR as well.

phausler · 2016-08-16T15:54:46Z

yep that is totally a duplicate, I will defer to the other PR as long as we can get this done.

RLovelett · 2016-08-16T16:00:43Z

@phausler I too want to see this concept get merged.

Though I don't want to decide who is a duplicate of what. I just figured I would point it out since @shahmishal and @phausler are both "Apple member" contributors you might work for the same company. 😏

If I pointed it out then perhaps you could work it out amongst the group.

shahmishal · 2016-08-16T16:23:52Z

@phausler sorry, I missed this PR. I will use this PR to verify all of the jobs have been setup correctly.

shahmishal · 2016-08-16T16:26:26Z

@swift-ci please test Linux

phausler · 2016-08-16T19:29:10Z

So further digging into the dispatch_io test failures:

[SKIP] Large file not found (dispatch_io.c:82)
[SKIP] Large file not found (dispatch_io.c:82)
[SKIP] Large file not found (dispatch_io.c:82)
[SKIP] Large file not found (dispatch_io.c:82)
[SKIP] Large file not found (dispatch_io.c:82)
[SKIP] Large file not found (dispatch_io.c:82)
...
[BEGIN] open
    Actual: 2   No such file or directory
    Expected: 0
[FAIL] open (dispatch_io.c:246)
    dispatch_io.c:246
[BEGIN] Leaks
    Actual: 256
    Expected: 0
[FAIL] Leaks (bsdtests.c:464)
    bsdtests.c:464

dispatch_io_net

[BEGIN] client-open
    Actual: 2   No such file or directory
    Expected: 0
[FAIL] client-open (dispatch_io_net.c:97)
    dispatch_io_net.c:97

[BEGIN] open
    Actual: 2   No such file or directory
    Expected: 0
[FAIL] open (dispatch_io_net.c:236)
    dispatch_io_net.c:236

[BEGIN] Leaks
    Actual: 256
    Expected: 0
[FAIL] Leaks (bsdtests.c:464)
    bsdtests.c:464

[BEGIN] Leaks
    Actual: 256
    Expected: 0
[FAIL] Leaks (bsdtests.c:464)
    bsdtests.c:464

dispatch_select

==================================================
[TEST] Dispatch select workaround test
[PID] 6576
==================================================


[BEGIN] main_q
    Actual: 0x607280
    Expected: 0x607280
[PASS] main_q

[BEGIN] select source
    Actual: 0x7f4d1c0008c0
    Expected: 0x7f4d1c0008c0
[PASS] select source

[BEGIN] kevent read 1
    Actual: 20.000000
    Expected: <=512001.000000
[PASS] kevent read 1

[BEGIN] close
    Actual: 0
    Expected: 0
[PASS] close
/usr/share/dict/words: No such file or directory

RLovelett · 2016-08-16T19:32:35Z

https://lists.swift.org/pipermail/swift-corelibs-dev/Week-of-Mon-20160808/000863.html

phausler · 2016-08-16T19:40:44Z

@dgrove-oss, @das, @MadCoder can we just disable these tests for now and get this landed (and then perhaps revisit adding better support for these tests to have proper files to transact upon as part of the testing suite?

dgrove-oss · 2016-08-16T19:57:31Z

Disabling the test for now makes sense to me. We can make a pass through the test suite soon and do a better job of dealing with expected input files not being present.

dgrove-oss · 2016-08-16T20:08:07Z

dispatch PR swiftlang/swift-corelibs-libdispatch#151

I'll work on something less hacky (for example checking for /usr/share/dict/words in configure) and submit that later.

phausler · 2016-08-19T17:08:53Z

@swift-ci Please test linux

swift-ci · 2016-08-19T17:16:36Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 8d43142
Test requested by - @phausler

phausler · 2016-08-19T17:20:32Z

This is now failing again on autoreconf not being run again

parkera · 2016-08-19T17:47:09Z

cc @seabaylea

phausler · 2016-08-19T17:59:08Z

@swift-ci please test Linux

swift-ci · 2016-08-19T18:09:46Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 8d43142
Test requested by - @phausler

phausler · 2016-08-19T18:18:08Z

@swift-ci Please test linux

shahmishal · 2016-08-19T18:39:03Z

@swift-ci Please test Linux

seabaylea · 2016-08-19T18:50:02Z

It looks like, for whatever reason, the previous build (before the debug) didn't pick up the reconfigure changes. FYI, those build fine for me locally.

phausler · 2016-08-19T19:23:01Z

@swift-ci Please smoke test OS X platform

phausler · 2016-08-19T21:30:47Z

It is green as of the latest build, going to remove the logging

phausler · 2016-08-19T21:32:36Z

@swift-ci Please test linux

phausler · 2016-08-19T22:36:40Z

@swift-ci please test

phausler · 2016-08-19T23:26:35Z

Why is the OS X smoke test not running?

parkera · 2016-08-20T05:37:33Z

This affects Linux only, so I'm merging it now.

gparker42 · 2016-08-20T08:08:28Z

Linux CI builds are broken again. I plan to revert this soon.
https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-15_10/7448/

seabaylea · 2016-08-20T08:57:35Z

Mishal has just updated the build environments, which should fix the breakages.

gparker42 · 2016-08-20T09:08:11Z

I don't think Mishal's changes fixed the timeout in libdispatch's tests. I think this build has the update but it's stuck and is probably going to fail in a few minutes.
https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-15_10/7450/

seabaylea · 2016-08-20T09:22:45Z

Yes - looks like it hung in the dispatch_cascade test for some reason:

==================================================
[TEST] Dispatch Cascade
[PID] 19223
==================================================


[BEGIN] Process exited
    Actual: 1
    Expected: 0
[FAIL] Process exited (bsdtestharness.c:132)
    bsdtestharness.c:132
[PERF]  wall time: 0.034725
[PERF]  user time: 0.056000
[PERF]  system time: 0.008000
[PERF]  max resident set size: 17660
[PERF]  page faults: 0
[PERF]  swaps: 0
[PERF]  voluntary context switches: 43
[PERF]  involuntary context switches: 10
FAIL dispatch_cascade (exit status: 1)

That's not a failure that we'd had before. I'll quickly push a PR to disable the test for now.

seabaylea · 2016-08-20T09:25:37Z

Ok - I've just disabled the test in libdispatch master.

* Try installing specific Wasmer version * Add missing repositories to `update-checkout-config.json` * Pin Wasmer to 2.1.1 on Linux

RLovelett reviewed Aug 14, 2016
View reviewed changes

build libdispatch by default in both linux build bot configurations

8d43142

phausler force-pushed the build_libdispatch_by_default branch from 675263d to 8d43142 Compare August 15, 2016 16:03

RLovelett mentioned this pull request Aug 15, 2016

[SR-1613][SourceKit] Require blocks runtime #2703

Merged

1 task

RLovelett mentioned this pull request Aug 16, 2016

[Preset] Add libdispatch in Linux presets #4315

Closed

1 task

reconfigure libdispatch when asked to by the build script

0ca01e1

Add logging diagnostics to nail down the build script failures

f131f82

Remove logging call to which on autoreconf

3951bf8

parkera merged commit 59a7c73 into swiftlang:master Aug 20, 2016

gparker42 mentioned this pull request Aug 20, 2016

Revert "build libdispatch by default in both linux build bot configurations" #4432

Closed

itaiferber mentioned this pull request Aug 26, 2016

[DO NOT MERGE YET] Cherry-pick commits required for swift-3.0-branch Foundation integration #4528

Merged

kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022

Pin Wasmer version to prevent test failures (#4203)

0d66537

* Try installing specific Wasmer version * Add missing repositories to `update-checkout-config.json` * Pin Wasmer to 2.1.1 on Linux

build libdispatch by default in both linux build bot configurations #4203

build libdispatch by default in both linux build bot configurations #4203

Uh oh!

Conversation

phausler commented Aug 10, 2016

What's in this pull request?

Uh oh!

phausler commented Aug 10, 2016

Uh oh!

tkremenek commented Aug 13, 2016

Uh oh!

compnerd commented Aug 13, 2016

Uh oh!

tkremenek commented Aug 14, 2016

Uh oh!

RLovelett Aug 14, 2016

Choose a reason for hiding this comment

Uh oh!

phausler Aug 14, 2016

Choose a reason for hiding this comment

Uh oh!

phausler commented Aug 15, 2016

Uh oh!

jrose-apple commented Aug 15, 2016

Uh oh!

jrose-apple commented Aug 15, 2016

Uh oh!

jrose-apple commented Aug 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tkremenek commented Aug 16, 2016

Uh oh!

phausler commented Aug 16, 2016

Uh oh!

phausler commented Aug 16, 2016

Uh oh!

jrose-apple commented Aug 16, 2016

Uh oh!

jrose-apple commented Aug 16, 2016

Uh oh!

RLovelett commented Aug 16, 2016

Uh oh!

phausler commented Aug 16, 2016

Uh oh!

RLovelett commented Aug 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahmishal commented Aug 16, 2016

Uh oh!

shahmishal commented Aug 16, 2016

Uh oh!

phausler commented Aug 16, 2016

Uh oh!

RLovelett commented Aug 16, 2016

Uh oh!

phausler commented Aug 16, 2016

Uh oh!

dgrove-oss commented Aug 16, 2016

Uh oh!

dgrove-oss commented Aug 16, 2016

Uh oh!

phausler commented Aug 19, 2016

Uh oh!

swift-ci commented Aug 19, 2016

Uh oh!

phausler commented Aug 19, 2016

Uh oh!

parkera commented Aug 19, 2016

Uh oh!

phausler commented Aug 19, 2016

Uh oh!

swift-ci commented Aug 19, 2016

Uh oh!

phausler commented Aug 19, 2016

Uh oh!

shahmishal commented Aug 19, 2016

Uh oh!

seabaylea commented Aug 19, 2016

Uh oh!

phausler commented Aug 19, 2016

jrose-apple commented Aug 15, 2016 •

edited

Loading

RLovelett commented Aug 16, 2016 •

edited

Loading

seabaylea commented Aug 20, 2016 •

edited

Loading