IRGen: Artificially pad async let entry point contexts. #42037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fixed a bug in the concurrency runtime (rdar://problem/90357994) that would lead to memory corruption when a new `async let` child task tried to use the last 16 bytes of the preallocated slab from its parent to seed its own task allocator. To work around this bug in older OSes that shipped with the bug, artificially pad the async coroutine context size for any async functions used as an `async let` entry point, which will prevent the runtime from going down the path of trying to use the preallocated storage at all. rdar://90506708
|
@swift-ci Please test |
mikeash
approved these changes
Mar 28, 2022
| @@ -328,10 +328,10 @@ class IRGenerator { | |||
|
|
|||
| /// The queue of IRGenModules for multi-threaded compilation. | |||
| SmallVector<IRGenModule *, 8> Queue; | |||
|
|
|||
There was a problem hiding this comment.
Tiny bit of whitespace schmutz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fixed a bug in the concurrency runtime (rdar://problem/90357994) that would
lead to memory corruption when a new
async letchild task tried to use thelast 16 bytes of the preallocated slab from its parent to seed its own task
allocator. To work around this bug in older OSes that shipped with the bug,
artificially pad the async coroutine context size for any async functions
used as an
async letentry point, which will prevent the runtime fromgoing down the path of trying to use the preallocated storage at all.
rdar://90506708