Derive nonisolated members for protocol conformances #42041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deriving witnesses for protocol conformances within an actor-isolated type, make those members 'nonisolated'. In the case where this would work, for example because some of the state is mutable, don't allow derivation of those witnesses. Fixes rdar://90233250.
|
@swift-ci please smoke test |
ktoso
approved these changes
Mar 26, 2022
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Nov 9, 2022
…ods. swiftlang#42041 introduced a centralized mechanism for adding the `nonisolated` attribute to synthesized decls but did not clean up the existing code that was already doing so for `Hashable` conformances. Resolves rdar://102106591
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Nov 9, 2022
…ods. swiftlang#42041 introduced a centralized mechanism for adding the `nonisolated` attribute to synthesized decls but did not clean up the existing code that was already doing so for `Hashable` conformances. Resolves rdar://102106591
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Nov 9, 2022
…ods. swiftlang#42041 introduced a centralized mechanism for adding the `nonisolated` attribute to synthesized decls but did not clean up the existing code that was already doing so for `Hashable` conformances. Resolves rdar://102106591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deriving witnesses for protocol conformances within an
actor-isolated type, make those members 'nonisolated'. In the case
where this would work, for example because some of the state is
mutable, don't allow derivation of those witnesses.
Fixes rdar://90233250.