[move-function] Add tests for debug info for owned arguments. #42053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… /after/ the reinit. Otherwise, the memory lifetime verifier complains we are using the value while it is not initialized. I actually did this correctly in the single block impl. Just a small thinko.
Some notes: 1. I only updated the dwarf dump checks for the cases where the test case I was adding already had checks. The rest I am going to add the dwarf checks all at once in a subsequent commit. 2. In the dwarf checks that I wrote, there are a few issues that show up due to some LLVM fixes that I need to finish upstreaming. Once I upstream them, I will be able to enable the specific patterns I have disabled. This ensures I atleast will be able to tell if I am changing the current codegen. 3. This is dependent on the previous commit since one of the test cases hit the bug fixed by the previous commit.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes a small issue where I was inserted a debug_info inst before a reinit instead of after. The main commit is the 2nd one.
[move-function] Add tests for debug info for owned arguments.
Some notes:
I only updated the dwarf dump checks for the cases where the test case I was
adding already had checks. The rest I am going to add the dwarf checks all at
once in a subsequent commit.
In the dwarf checks that I wrote, there are a few issues that show up due to
some LLVM fixes that I need to finish upstreaming. Once I upstream them, I will
be able to enable the specific patterns I have disabled. This ensures I atleast
will be able to tell if I am changing the current codegen.
This is dependent on the previous commit since one of the test cases hit the
bug fixed by the first commit in the PR.