IRGen: Fix enable-testing of internal with resilient super class #42063
Conversation
|
@swift-ci Please test |
| /*useDC=*/nullptr, | ||
| /*treatUsableFromInlineAsPublic=*/true) | ||
| .isPublic()); | ||
| if (IGM.hasResilientMetadata(superclassDecl, |
There was a problem hiding this comment.
Can we fold this into a new IGM.hasResilientSuperclass() which takes the class (and not the superclass) and then does the necessary checks?
There was a problem hiding this comment.
We need to "pass down" the fact that the super class is not to be treated as resilient to the recursive call addFieldsForClass /addClassMembers on the super class.
There was a problem hiding this comment.
Right, maybe there's some other way, but this is the second bug we've fixed related to enable-testing vs class resilience, and it looks like both fixes added accidental complexity. We're just factoring the computations incorrectly here.
Enable testing makes `internal` types visible from outside the module. We can no longer treat super classes as resilient. Follow-up to swiftlang#41044. rdar://90489618
aschwaighofer
force-pushed
the
fix_internal_resilient_super_class_with_enable_testing
branch
from
b7f0138 to
3930fc4
Compare
|
@slavapestov I have changed the patch so that we are now additionally passing a |
|
@swift-ci Please test |
Enable testing makes
internaltypes visible from outside the module.We can no longer treat super classes as resilient.
Follow-up to #41044.
rdar://90489618