Tests: Use REQUIRES: maccatalyst_support instead of REQUIRES: OS=maccatalyst
#42068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
…accatalyst` whereever possible to broaden coverage for MacCatalyst specific tests. These tests did not need the runtime OS to be MacCatalyst; they need the compiler to support `macabi` triples (e.g. `-target x86_64-apple-ios13.1-macabi`). Also, fix a few tests that had rotted because they had not been running in CI. Resolves rdar://90937822
tshortli
force-pushed
the
use-requires-maccatalyst-support-instead-of-os-maccatalyst
branch
from
389c0e6 to
3100693
Compare
|
@swift-ci please test |
tshortli
deleted the
use-requires-maccatalyst-support-instead-of-os-maccatalyst
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
REQUIRES: maccatalyst_supportinstead ofREQUIRES: OS=maccatalystwhereever possible to broaden coverage for MacCatalyst specific tests. These tests did not need the runtime OS to be MacCatalyst; they need the compiler to supportmacabitriples (e.g.-target x86_64-apple-ios13.1-macabi).Also, disable a test that has rotted because it had not been running in CI.
Resolves rdar://90937822